Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (1ba386f) to head (174b60f).

@@            Coverage Diff            @@
##            master       #98   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           55        61    +6     
  Branches        20        22    +2     
=========================================
+ Hits            55        61    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Phillip9587 Using Buffer still seems incredibly fast when I check out this PR locally, are you seeing something different?

  decode base64-js - src/base64.bench.ts > base64 decode - short
    1.14x faster than decode Buffer
    2.38x faster than decode Uint8Array.fromBase64
    2.90x faster than decode @exodus/bytes

  encode Buffer - src/base64.bench.ts > base64 encode - short
    1.70x faster than encode @exodus/bytes
    2.50x faster than encode Uint8Array.toBase64
    3.28x faster than encode base64-js

  decode Buffer - src/base64.bench.ts > base64 decode - long
    1.97x faster than decode Uint8Array.fromBase64
    2.34x faster than decode @exodus/bytes
    2.51x faster than decode base64-js

  encode Buffer - src/base64.bench.ts > base64 encode - long
    2.25x faster than encode Uint8Array.toBase64
    2.38x faster than encode @exodus/bytes
    10.60x faster than encode base64-js

Makes me feel like it should still be Buffer and fallback on Uint8Array? Do you want older browser support without Uint8Array?

We may also want to consider applying size-limit if this is intended for browsers and other environments. I'm not sure pulling in that dependency is worth it.

@blakeembrey Hey, I took a look at your refactoring of my PR in #95. Please give me some time to explain my reasoning behind this PR versus #95. It’s currently holiday in Germany, so I’m away for the weekend.

Of course, no rush! In case it helps, my context is that it's a trade-off between package size and performance. Since Buffer is fastest anyway, and non-Buffer environments are package size constrained, it seemed best balance to ship something fast and small with the option of having those other environments opt-in via encode/decode options or polyfills to the larger package size.